fix(security): 2 improvements across 2 files#4135
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Predictable UUID version used for user identifiers - Security: Invitation/token values stored in plaintext Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Predictable UUID version used for user identifiers - Security: Invitation/token values stored in plaintext Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:packages/api/db/migration/20201130123842_change_user_id_to_uuid.js:L3The migration sets
users.user_iddefault touuid_generate_v1(), which is time/MAC-based and more predictable than random UUIDs. If user IDs are exposed through APIs, this can increase enumeration risk and leak metadata about creation time/host characteristics.Solution
Use
uuid_generate_v4()(orgen_random_uuid()in modern Postgres) for security-sensitive/public identifiers. Consider migrating existing externally exposed IDs to random UUIDs if feasible.Changes
packages/api/db/migration/20201130123842_change_user_id_to_uuid.js(modified)packages/api/db/migration/20200713160251_make_email_token_table.js(modified)